Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improving doc comments #5550

Merged
merged 9 commits into from
Feb 17, 2025
Merged

improving doc comments #5550

merged 9 commits into from
Feb 17, 2025

Conversation

rysweet
Copy link
Collaborator

@rysweet rysweet commented Feb 14, 2025

Why are these changes needed?

adding some missing doc comments

Related issue number

Checks

@rysweet rysweet requested a review from lokitoth February 14, 2025 16:45
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.91%. Comparing base (c76a68c) to head (3d3e3ca).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5550      +/-   ##
==========================================
- Coverage   78.74%   71.91%   -6.83%     
==========================================
  Files         167      236      +69     
  Lines       10025    11922    +1897     
  Branches        0      238     +238     
==========================================
+ Hits         7894     8574     +680     
- Misses       2131     3163    +1032     
- Partials        0      185     +185     
Flag Coverage Δ
unittests 71.91% <ø> (-6.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rysweet rysweet enabled auto-merge (squash) February 14, 2025 21:13
Copy link
Contributor

@raimondasl raimondasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good if you fixed the comments. Thanks

@rysweet rysweet merged commit 2a90731 into main Feb 17, 2025
50 checks passed
@rysweet rysweet deleted the rysweet-doc-comments branch February 17, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants