Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Gallery Editor UX in AGS #5613

Merged
merged 18 commits into from
Feb 21, 2025
Merged

Improve Gallery Editor UX in AGS #5613

merged 18 commits into from
Feb 21, 2025

Conversation

victordibia
Copy link
Collaborator

@victordibia victordibia commented Feb 19, 2025

Why are these changes needed?

Fixes the problem where Gallery items could only be modified via JSON

This PR does the following

  • Refactor TeamBuilder to have modular component editor UI primarily focused on editing each component type.
  • Refactor the Gallery UX
    • improve layout to use tabs for each component type
    • enable editing of each component item by reusing the component editor
  • Enable switching between form editing and UI editing for coponent editor view

This way, gallery items can be readily modified and then reused in the component library in team builder.
It also implements an upate to the Gallery data structure to make it more intuitive - it has a components field that has teams, agents, models ...

image image

Related issue number

Closes #5465
Closes #5047

cc @nour-bouzid @balakreshnan @EItanya @joslat @IustinT @LeonG7

Checks

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.41%. Comparing base (34d30b5) to head (ff7af4c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5613   +/-   ##
=======================================
  Coverage   75.41%   75.41%           
=======================================
  Files         171      171           
  Lines       10467    10467           
=======================================
  Hits         7894     7894           
  Misses       2573     2573           
Flag Coverage Δ
unittests 75.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@victordibia victordibia merged commit 2f43005 into main Feb 21, 2025
54 checks passed
@victordibia victordibia deleted the ags_tools_improvement branch February 21, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AGS - Improve UX for modifying Gallery Items AutoGen Studio: Improve Gallery UX.
2 participants