Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding types to mxgraph. #182

Merged
merged 15 commits into from
Dec 13, 2024
Merged

Adding types to mxgraph. #182

merged 15 commits into from
Dec 13, 2024

Conversation

aasimkhan30
Copy link
Collaborator

@aasimkhan30 aasimkhan30 commented Dec 12, 2024

This PR integrates typings from typed-mxgraph(https://github.com/typed-mxgraph/typed-mxgraph) and updates the development workflow to better support TypeScript in the project.

Changes in this PR:

  1. Type Definitions:

    • Added all mxgraph types to src/ts/mxtypings.
  2. Project Structure:

    • TypeScript source files will now be in src/ts/.
    • The original mxgraph code remains in src/js/.
  3. Recompiling Workflow:

    • After making changes to any code in src/js (original mx source), run yarn compile-mxgraph to compile mxgraph and update the typings in src/ts/mxtypings.
  4. Bundling:

    • Added esbuild to bundle everything into a single file, ensuring compatibility with simple HTML examples.
  5. Examples:

    • New TypeScript examples are now located in the examples-ts folder.
  6. Updated Documentation:

    • The readme has been updated to include linting information and the new workflow.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 165 out of 171 changed files in this pull request and generated no suggestions.

Files not reviewed (6)
  • .npmignore: Language not supported
  • index.html: Language not supported
  • package.json: Language not supported
  • .github/workflows/cd.yml: Evaluated as low risk
  • README.md: Evaluated as low risk
  • .github/workflows/ci.yml: Evaluated as low risk
Comments skipped due to low confidence (1)

build.js:94

  • The error handling in the prependText function should be improved. The fs.close method should handle errors properly.
fs.close(fd, (err) => {
@aasimkhan30 aasimkhan30 merged commit 5e679b9 into main Dec 13, 2024
4 checks passed
@aasimkhan30 aasimkhan30 deleted the aasim/fix/ts-azdataGraph2 branch December 13, 2024 15:05
Copy link
Member

@kburtram kburtram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants