Updated publish methods' to keep it compatible #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-smolyakov
approved these changes
Jan 11, 2021
DaniilShmelev
approved these changes
Jan 11, 2021
EzzhevNikita
approved these changes
Jan 11, 2021
anatolybolshakov
approved these changes
Jan 11, 2021
egor-bryzgalov
deleted the
users/egor-bryzgalov/publish-methods-sign-changed
branch
fullstackinfo
pushed a commit
to fullstackinfo/azure-pipelines-task-lib
that referenced
this pull request
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated publish methods' to keep it compatible with tasks using different argument types.
Related issue (internal): #356
The approach was chosen taking the following case into consideration:
If an empty string is passed to
publishmethod ofCodeCoveragePublisherclass asadditionalCodeCoverageFilesargument we would get the following result:##vso[codecoverage.publish]If we try to pass an empty array we would get:
##vso[codecoverage.publish additionalcodecoveragefiles=;]The approach is to pass a string in any case since it's expected by the
TaskCommandclass.