Added new required functions #827
Conversation
|
|
…r undefined. getInputRequired getPathInputRequired getEndpointUrlRequired getEndpointDataParameterRequired getEndpointAuthorizationSchemeRequired getEndpointAuthorizationParameterRequired
|
I can also adjust naming or anything else if there's a suggestion. |
node/task.ts
Outdated
| * @returns string | ||
| */ | ||
| export function getInputRequired(name: string): string { | ||
| var inval = im._vault.retrieveSecret('INPUT_' + im._getVariableKey(name)); |
There was a problem hiding this comment.
Please use the call of existing methods instead (like getInput(name, required) - to avoid duplication (and for other methods also)
There was a problem hiding this comment.
Do you mean that I should have getInputRequired call getInput so that the internals of that method are not duplicated?
There was a problem hiding this comment.
@Banner-Keith yep correct 👍
|
Thanks for contribution! Could you please take a look at comments? |
|
@anatolybolshakov sorry for the delay. I have made the adjustment you requested. |
|
@Banner-Keith thanks for update! Let us quickly check |
There was a problem hiding this comment.
LGTM, thanks! @SvetlanaMaliugina could you please take a look also?
|
@mmrazik could you please take a look also? |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
* Added new required functions. Return the value instead of the value or undefined. getInputRequired getPathInputRequired getEndpointUrlRequired getEndpointDataParameterRequired getEndpointAuthorizationSchemeRequired getEndpointAuthorizationParameterRequired * Fix undefined in json file * Simplify Required functions. Add tests. Co-authored-by: Keith Banner <[email protected]>
Return the value instead of the value or undefined.
getInputRequired
getPathInputRequired
getEndpointUrlRequired
getEndpointDataParameterRequired
getEndpointAuthorizationSchemeRequired
getEndpointAuthorizationParameterRequired