Add fallback keys to caching #10847
Closed
Add fallback keys to caching #10847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnterickson
commented
Jul 5, 2019
| "loc.input.help.cacheHitVar": "Variable to set to 'true' when the cache is restored (i.e. a cache hit), otherwise set to 'false'." | ||
| "loc.input.help.cacheHitVar": "Variable to set to 'true' when the cache is restored (i.e. a cache hit), otherwise set to 'false'.", | ||
| "loc.input.label.fallbackKeys": "Fallback keys", | ||
| "loc.input.help.fallbackKeys": "TODO" |
owenhuynMSFT
reviewed
Jul 8, 2019
| @@ -8,5 +8,7 @@ | |||
| "loc.input.label.path": "Path", | |||
| "loc.input.help.path": "Path of the folder to cache. Can be fully-qualified or relative to $(System.DefaultWorkingDirectory). Wildcards are not supported. [Variables](https://go.microsoft.com/fwlink/?LinkID=550988) are supported.", | |||
| "loc.input.label.cacheHitVar": "Cache hit variable", | |||
| "loc.input.help.cacheHitVar": "Variable to set to 'true' when the cache is restored (i.e. a cache hit), otherwise set to 'false'." | |||
| "loc.input.help.cacheHitVar": "Variable to set to 'true' when the cache is restored (i.e. a cache hit), otherwise set to 'false'.", | |||
| "loc.input.label.fallbackKeys": "Fallback keys", | |||
There was a problem hiding this comment.
We need to what the variable is set to when the fallback is grabbed instead.
johnterickson
force-pushed
the
users/jerick/fallback
branch
from
a5b1eff to
c1f3edd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to wait for agent with microsoft/azure-pipelines-agent#2358 to be deployed.