-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance MySQL firewall public IP for local PC #5163
Conversation
...intellij/src/com/microsoft/azure/toolkit/intellij/connector/mysql/MySQLDatabaseResource.java
Outdated
Show resolved
Hide resolved
Utils/azuretools-core/src/com/microsoft/azuretools/core/mvp/model/mysql/MySQLMvpModel.java
Outdated
Show resolved
Hide resolved
Utils/azuretools-core/src/com/microsoft/azuretools/core/mvp/model/mysql/MySQLMvpModel.java
Outdated
Show resolved
Hide resolved
...rc/com/microsoft/azure/toolkit/intellij/connector/mysql/MySQLDatabaseResourceConnection.java
Outdated
Show resolved
Hide resolved
Utils/azuretools-core/src/com/microsoft/azuretools/core/mvp/model/mysql/MySQLMvpModel.java
Outdated
Show resolved
Hide resolved
Utils/azuretools-core/src/com/microsoft/azuretools/core/mvp/model/mysql/MySQLMvpModel.java
Outdated
Show resolved
Hide resolved
@@ -213,8 +213,8 @@ public static boolean isAllowAccessFromLocalMachine(final String subscriptionId, | |||
} | |||
|
|||
public static boolean isAllowAccessFromLocalMachine(final List<FirewallRuleInner> firewallRules) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's weird that we have to pass firewallRules
as the parameter. I naturally think we should pass server
as the parameter.
e.g. isLocalMachineAllowedAccess(server)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isLocalMachineAllowedAccess(server) existed as well. it is a polymorphic one. in order to void to list firewall rules twice when when need to calculate access to local PC and other azure services.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then this method may be renamed to something like isLocalMachineIncluded(rules)
...e-toolkit-for-intellij/src/com/microsoft/azure/toolkit/intellij/mysql/MySQLPropertyView.java
Outdated
Show resolved
Hide resolved
Utils/azuretools-core/src/com/microsoft/azuretools/utils/NetUtils.java
Outdated
Show resolved
Hide resolved
it's basically OK for me about the logic part. and you may simplify the code by only providing these meta methods for firewall rules:
so that, e.g.
|
The base branch was changed.
No description provided.