Skip to content

Commit

Permalink
Remove deprecated "Asynchronous Processing" connection property (#20830)
Browse files Browse the repository at this point in the history
  • Loading branch information
cheenamalhotra authored Oct 14, 2022
1 parent 23dfe62 commit 80bdc3d
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 51 deletions.
14 changes: 0 additions & 14 deletions extensions/cms/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -165,20 +165,6 @@
"isRequired": false,
"isArray": false
},
{
"specialValueType": null,
"isIdentity": false,
"name": "asynchronousProcessing",
"displayName": "%cms.connectionOptions.asynchronousProcessing.displayName%",
"description": "%cms.connectionOptions.asynchronousProcessing.description%",
"groupName": "%cms.connectionOptions.groupName.initialization%",
"valueType": "boolean",
"defaultValue": null,
"objectType": null,
"categoryValues": null,
"isRequired": false,
"isArray": false
},
{
"specialValueType": null,
"isIdentity": false,
Expand Down
2 changes: 0 additions & 2 deletions extensions/cms/package.nls.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,6 @@
"cms.connectionOptions.password.description": "Indicates the password to be used when connecting to the data source",
"cms.connectionOptions.applicationIntent.displayName": "Application intent",
"cms.connectionOptions.applicationIntent.description": "Declares the application workload type when connecting to a server",
"cms.connectionOptions.asynchronousProcessing.displayName": "Asynchronous processing",
"cms.connectionOptions.asynchronousProcessing.description": "When true, enables usage of the Asynchronous functionality in the .Net Framework Data Provider",
"cms.connectionOptions.connectTimeout.displayName": "Connect timeout",
"cms.connectionOptions.connectTimeout.description": "The length of time (in seconds) to wait for a connection to the server before terminating the attempt and generating an error",
"cms.connectionOptions.currentLanguage.displayName": "Current language",
Expand Down
14 changes: 0 additions & 14 deletions extensions/mssql/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -946,20 +946,6 @@
"isRequired": false,
"isArray": false
},
{
"specialValueType": null,
"isIdentity": false,
"name": "asynchronousProcessing",
"displayName": "%mssql.connectionOptions.asynchronousProcessing.displayName%",
"description": "%mssql.connectionOptions.asynchronousProcessing.description%",
"groupName": "%mssql.connectionOptions.groupName.initialization%",
"valueType": "boolean",
"defaultValue": null,
"objectType": null,
"categoryValues": null,
"isRequired": false,
"isArray": false
},
{
"specialValueType": null,
"isIdentity": false,
Expand Down
2 changes: 0 additions & 2 deletions extensions/mssql/package.nls.json
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,6 @@
"mssql.connectionOptions.password.description": "Indicates the password to be used when connecting to the data source",
"mssql.connectionOptions.applicationIntent.displayName": "Application intent",
"mssql.connectionOptions.applicationIntent.description": "Declares the application workload type when connecting to a server",
"mssql.connectionOptions.asynchronousProcessing.displayName": "Asynchronous processing",
"mssql.connectionOptions.asynchronousProcessing.description": "When true, enables usage of the Asynchronous functionality in the .Net Framework Data Provider",
"mssql.connectionOptions.connectTimeout.displayName": "Connect timeout",
"mssql.connectionOptions.connectTimeout.description": "The length of time (in seconds) to wait for a connection to the server before terminating the attempt and generating an error",
"mssql.connectionOptions.currentLanguage.displayName": "Current language",
Expand Down
8 changes: 1 addition & 7 deletions resources/xlf/en/cms.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,6 @@
<trans-unit id="cms.connectionOptions.applicationName.displayName">
<source xml:lang="en">Application name</source>
</trans-unit>
<trans-unit id="cms.connectionOptions.asynchronousProcessing.description">
<source xml:lang="en">When true, enables usage of the Asynchronous functionality in the .Net Framework Data Provider</source>
</trans-unit>
<trans-unit id="cms.connectionOptions.asynchronousProcessing.displayName">
<source xml:lang="en">Asynchronous processing</source>
</trans-unit>
<trans-unit id="cms.connectionOptions.attachDbFilename.displayName">
<source xml:lang="en">Attach DB filename</source>
</trans-unit>
Expand Down Expand Up @@ -402,4 +396,4 @@
<source xml:lang="en">Version</source>
</trans-unit>
</body></file>
</xliff>
</xliff>
8 changes: 1 addition & 7 deletions resources/xlf/en/mssql.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -724,12 +724,6 @@
<trans-unit id="mssql.connectionOptions.applicationName.displayName">
<source xml:lang="en">Application name</source>
</trans-unit>
<trans-unit id="mssql.connectionOptions.asynchronousProcessing.description">
<source xml:lang="en">When true, enables usage of the Asynchronous functionality in the .Net Framework Data Provider</source>
</trans-unit>
<trans-unit id="mssql.connectionOptions.asynchronousProcessing.displayName">
<source xml:lang="en">Asynchronous processing</source>
</trans-unit>
<trans-unit id="mssql.connectionOptions.attachDbFilename.displayName">
<source xml:lang="en">Attach DB filename</source>
</trans-unit>
Expand Down Expand Up @@ -1224,4 +1218,4 @@ Dashboard</source>
<source xml:lang="en">Tasks</source>
</trans-unit>
</body></file>
</xliff>
</xliff>
10 changes: 5 additions & 5 deletions src/sql/workbench/test/browser/modal/optionsDialogHelper.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ suite('Advanced options helper tests', () => {
};

booleanOption = {
name: 'asynchronousProcessing',
displayName: 'Asynchronous processing enabled',
description: 'When true, enables usage of the Asynchronous functionality in the .Net Framework Data Provider',
name: 'trustServerCertificate',
displayName: 'Trust Server Certificate enabled',
description: 'When true (and encrypt=true), SQL Server uses SSL encryption for all data sent between the client and server without validating the server certificate',
groupName: 'Initialization',
categoryValues: null,
defaultValue: null,
Expand Down Expand Up @@ -228,7 +228,7 @@ suite('Advanced options helper tests', () => {
booleanOption.defaultValue = null;
booleanOption.isRequired = false;
possibleInputs = [];
options['asynchronousProcessing'] = true;
options['trustServerCertificate'] = true;
let optionValue = OptionsDialogHelper.getOptionValueAndCategoryValues(booleanOption, options, possibleInputs);
assert.strictEqual(optionValue, 'True');
assert.strictEqual(possibleInputs.length, 3);
Expand All @@ -241,7 +241,7 @@ suite('Advanced options helper tests', () => {
booleanOption.defaultValue = null;
booleanOption.isRequired = true;
possibleInputs = [];
options['asynchronousProcessing'] = 'False';
options['trustServerCertificate'] = 'False';
let optionValue = OptionsDialogHelper.getOptionValueAndCategoryValues(booleanOption, options, possibleInputs);
assert.strictEqual(optionValue, 'False');
assert.strictEqual(possibleInputs.length, 2);
Expand Down

0 comments on commit 80bdc3d

Please sign in to comment.