Skip to content

Commit

Permalink
Review changes
Browse files Browse the repository at this point in the history
  • Loading branch information
lewis-sanchez committed Jan 16, 2025
1 parent c386092 commit bcfc30b
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions extensions/azurecore/src/account-provider/auths/azureAuth.ts
Original file line number Diff line number Diff line change
Expand Up @@ -462,11 +462,11 @@ export abstract class AzureAuth implements vscode.Disposable {
};

const httpConfig = vscode.workspace.getConfiguration("http");
const proxy = this.loadEnvironmentProxyValue() || httpConfig["proxy"] as string;
const proxy = httpConfig["proxy"] as string || this.loadEnvironmentProxyValue();
if (proxy) {
const agent = this.createProxyAgent(requestUrl, proxy, httpConfig["proxyStrictSSL"]);

if (proxy.includes("https")) {
if (proxy.startsWith("https")) {
config.httpsAgent = agent;
}
else {
Expand Down Expand Up @@ -524,8 +524,8 @@ export abstract class AzureAuth implements vscode.Disposable {
};
}

const isRequestHttps = requestUrl.includes("https");
const isProxyHttps = proxy.includes("https");
const isRequestHttps = requestUrl.startsWith("https");
const isProxyHttps = proxy.startsWith("https");
const proxyAgent = {
isHttps: isRequestHttps,
agent: this.createTunnelingAgent(isRequestHttps, isProxyHttps, tunnelOptions),
Expand Down

0 comments on commit bcfc30b

Please sign in to comment.