Allow flux to acces ACR via SP #241
Conversation
|
@samiyaakhtar test failure
|
|
This adds a generic kubernetes acr secret which the templates would have to explicitly use and technically should be covered by assigning the SP used to provision the cluster permissions to read ACR. |
cluster/common/flux/deploy_flux.sh
Outdated
| @@ -52,7 +52,7 @@ fi | |||
| # git url: where flux monitors for manifests | |||
| # git ssh secret: kubernetes secret object for flux to read/write access to manifests repo | |||
| echo "generating flux manifests with helm template" | |||
| if ! helm template . --name $RELEASE_NAME --namespace $KUBE_NAMESPACE --values values.yaml --output-dir ./$FLUX_MANIFESTS --set git.url=$GITOPS_SSH_URL --set git.branch=$GITOPS_URL_BRANCH --set git.secretName=$KUBE_SECRET_NAME --set git.path=$GITOPS_PATH --set git.pollInterval=$GITOPS_POLL_INTERVAL; then | |||
| if ! helm template . --name $RELEASE_NAME --namespace $KUBE_NAMESPACE --values values.yaml --output-dir ./$FLUX_MANIFESTS --set git.url=$GITOPS_SSH_URL --set git.branch=$GITOPS_URL_BRANCH --set git.secretName=$KUBE_SECRET_NAME --set git.path=$GITOPS_PATH --set git.pollInterval=$GITOPS_POLL_INTERVAL --set registry.acr.enabled=true; then | |||
There was a problem hiding this comment.
Should add a switch via terraform to enable the ACR access in the event people are NOT using ACR.
samiyaakhtar
changed the title
Deploy registry secrets for flux to have access to the ACR using an SP. (Flux uses imagePullSecrets to access the ACR and will not have access to it unless this secret is deployed, even if AKS has access. Without the secret, it's able to deploy the manifest but can't poll changes from registry)
This is related to issue #204