Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensibility for Teams AI - ability to add to User Agent for Teams AI telemetry #6701

Closed
corinagum opened this issue Oct 24, 2023 · 2 comments
Assignees
Labels
feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team.

Comments

@corinagum
Copy link

Related to microsoft/botbuilder-js#4552

Request is from https://github.com/microsoft/teams-ai team

ConnectorFactoryImpl

We are hoping to have the ability to add Teams AI information for SMBA to parse for telemetry.

Since Teams AI is JavaScript first, we request this would be done in the JS SDK first with fast follow for C# and Python

@tracyboehrer
Copy link
Member

This should probably be done as JS allows it, via ConfigurationBotFrameworkAuthentication. accepting a ConnectorClientOptions, on which a UserAgent value can be included. This value is added on to our SDK UserAgent value. For example: "TeamsAI/1.0" results in "botframework-connector/4.0.0 ms-rest-js/2.7.0 Node/v16.20.2 OS/(x64-Windows_NT-10.0.22621) TeamsAI/1.0".

There is no way to enforce this though. That is, a customer could simply remove/change this in the bot.

Could also possible allow for the ConnectorClientOptions to read from Config, but it would need to be added to JS and Python.

@tracyboehrer
Copy link
Member

Teams is going to subclass CloudAdapter and HttpClientFactory in order to provide appropriate requests and response headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Development

No branches or pull requests

3 participants