Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telemetry Headers #454

Closed
2 tasks done
Tracked by #195
, #953
...
corinagum opened this issue Aug 21, 2023 · 2 comments · Fixed by #1142
Closed
2 tasks done
Tracked by #195
, #953
...

Telemetry Headers #454

corinagum opened this issue Aug 21, 2023 · 2 comments · Fixed by #1142
Assignees
@aacebo
Labels
bot-framework work being tracked that needs to be done in the bot framework SDK JS & dotnet & Python Change or fix must apply to all three programming languages P0

Comments

@corinagum
Copy link
Collaborator

corinagum commented Aug 21, 2023 •
edited by aacebo
Loading

We need to add telemetry for tracking AI Library usage:

Users actively building using AI library - Test vs production
What are bot feature APIs they are using
MAU of app built via SDK

code

Make sure SMBA is logging correctly

Tasks
Preview Give feedback
  1. Adding telemetry to track SDK usage #598
    JS & dotnet & Python P0
    Stevenic govil1811
  2. [C#] Implement Logging and Telemetry #745
    P0 dotnet small
    aacebo
@corinagum corinagum self-assigned this Aug 21, 2023
@corinagum corinagum mentioned this issue Aug 24, 2023
Closed
@corinagum corinagum changed the title Telemetry headers Telemetry headers [blocked until unification complete] Aug 28, 2023
@corinagum corinagum changed the title Telemetry headers [blocked until unification complete] Telemetry headers Sep 28, 2023
@corinagum corinagum mentioned this issue Oct 24, 2023
Closed
@corinagum
Copy link
Collaborator Author

Requests made to botbuilder team:

microsoft/botbuilder-js#4552
microsoft/botbuilder-dotnet#6701
microsoft/botbuilder-python#2033

@corinagum corinagum added JS & dotnet & Python Change or fix must apply to all three programming languages bot-framework work being tracked that needs to be done in the bot framework SDK labels Dec 6, 2023
This was referenced Dec 8, 2023
Closed
Closed
@aacebo
Copy link
Collaborator

aacebo commented Dec 21, 2023

currently following up with SMBA on our side to make sure they can ingest custom headers we set. BF team should be able to start this work in the JS SDK early next year.

@aacebo aacebo changed the title Telemetry headers Telemetry Headers Dec 21, 2023
@aacebo aacebo added the P0 label Dec 22, 2023
@aacebo aacebo assigned aacebo and unassigned corinagum Jan 9, 2024
@aacebo aacebo mentioned this issue Jan 9, 2024
Merged
aacebo added a commit that referenced this issue Jan 16, 2024
@aacebo @corinagum
[JS] feat: add user agent override and internalize BotAdapter (#1142)
2d43f5c 
## Linked issues

closes: #454 

## Details

In order to configure the `User-Agent` header for telemetry, I have
added the class `TeamsBotFrameworkAuthentication` which will allow us to
control the headers while still giving the devs implementation
flexibility:

- we can control how the bot adapter is initialized and provide
overrides when necessary.
- we can add an `error` handler on the `Application` class.
- we can cut down on botbuilder boilerplate necessary for users to use
our library.

---------

Co-authored-by: Corina <[email protected]>
@aacebo aacebo reopened this Jan 16, 2024
@aacebo aacebo mentioned this issue Jan 16, 2024
Merged
aacebo added a commit that referenced this issue Jan 17, 2024
@aacebo
[C#] feat: add adapter for telemetry headers (#1174)
274419c 
## Linked issues

closes: #745 #454 

## Details

add a new type of `BotAdapter` that ensures our telemetry headers are
added.

- add `TeamsAdapter` and make it the required form of `BotAdapter`
- update `js` implementation to match `dotnet`
@aacebo aacebo closed this as completed Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aacebo aacebo

Labels
bot-framework work being tracked that needs to be done in the bot framework SDK JS & dotnet & Python Change or fix must apply to all three programming languages P0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[JS] feat: add user agent override and internalize BotAdapter microsoft/teams-ai
2 participants
@corinagum @aacebo