This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
[Samples] Add 11.qnamaker bot sample #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add deploymentTemplates folder * Fix templates
* Add qnabot class * Add pom * Add feedback changes * Remove join() calls
* Add Application class * Implement the use of ConfigurationCredentialProvider * Apply feedback
tracyboehrer
suggested changes
Feb 26, 2021
| }; | ||
|
|
||
| // The actual call to the QnA Maker service. | ||
| qnaMaker.getAnswers(turnContext, options).thenAccept(response -> { |
There was a problem hiding this comment.
This should be:
// The actual call to the QnA Maker service.
return qnaMaker.getAnswers(turnContext, options)
.thenCompose(response -> {
if (response != null && response.length > 0) {
return turnContext.sendActivity(MessageFactory.text(response[0].getAnswer()))
.thenApply(sendResult -> null);
}
else {
return turnContext.sendActivity(MessageFactory.text("No QnA Maker answers were found."))
.thenApply(sendResult -> null);
}
});
| @@ -0,0 +1,42 @@ | |||
| { | |||
There was a problem hiding this comment.
new-rg-parameters.json can be removed.
| @@ -0,0 +1,39 @@ | |||
| { | |||
There was a problem hiding this comment.
preexisting-rg-parameters.json can be removed.
| @@ -0,0 +1,183 @@ | |||
| { | |||
There was a problem hiding this comment.
Update template-with-new-rg.json with version from 02.echo-bot
| @@ -0,0 +1,154 @@ | |||
| { | |||
There was a problem hiding this comment.
Update template-with-preexisting-rg.json with version from 02.echo-bot
|
@Batta32 Also need to update from main |
|
Thanks @tracyboehrer for your feedback. We will be applying the requested changes right now! |
matiasroldan6
added a commit
to southworks/botbuilder-java
that referenced
this pull request
Feb 26, 2021
|
@tracyboehrer - we already applied the requested changes and merged |
tracyboehrer
approved these changes
Feb 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #864
Description
We are adding the sample 11.qnamaker in Java taking into account the C# 11.qnamaker bot present in BotBuilder-Samples repository.
Specific Changes
resourcesfolder with sample questions tsvdeploymentTemplatesfolderapplication.propertiesTesting
Current behavior of the Java migrated sample
