-
Notifications
You must be signed in to change notification settings - Fork 115
[SDK][Bot-Azure] Add CosmosDbPartitionedStorage component #1024
[SDK][Bot-Azure] Add CosmosDbPartitionedStorage component #1024
Conversation
@tracyboehrer we noticed that the build is failing, most likely due to the bot-azure tests. Those unit tests contain the following requirements to be executed:
This is because Java needs the CosmosDbEmulator certificate in its We don't have permissions to analyze the build pipeline, however, let us know if you need help from our side for this 😊. |
@tracyboehrer we removed the following files as they are generated during the build:
We noticed that the .gitignore is missing a configuration for these files. Do you want us to add an entry in the configuration to ignore these binaries? |
@VictorGrycuk So these unit tests require the cosmosdb emulator and that appears to be why the PR build is failing. I need to look into how DotNet is dealing with this. |
@VictorGrycuk For the time being, I disabled running one of the unit tests for this in DevOps. This isn't a permanent solution, but we'll have to do some more research on our side. If you have the emulator installed, it will still run the unit tests as before. For DevOps, or if you try to run mvn and you DON'T have the emulator installed, you must include the following mvn options:
Not sure I really like this solution, but it does have the advantage of annoying me enough to provide motivation to solve the problem for real. |
Fixes #739
Description
Implements support for
CosmosDbPartitionedStorage
class and its tests.Specific Changes
Adds the following classes:
CosmosDbPartitionedStorage
CosmosDbPartitionedStorageOptions
CosmosDbKeyEscape
pom.xml
file with the necessary dependenciesCosmosDbPartitionedStorage
andCosmosDbKeyEscape
classesTesting
Unit tests of bot-azure passing correctly
mvn clean install passing correctly