This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 115
[SDK][Bot-Azure] Add BlobsStorage component #1066
Merged
tracyboehrer
merged 13 commits into
microsoft:main
from
southworks:external/feature/southworks/blobstorage/base
Mar 23, 2021
Merged
[SDK][Bot-Azure] Add BlobsStorage component #1066
tracyboehrer
merged 13 commits into
microsoft:main
from
southworks:external/feature/southworks/blobstorage/base
Mar 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @tracyboehrer, the unit test for this implementation requires Azure Storage Emulator, just like the PR #1033. |
* Apply Tracy feedback * Rename afterTest to testCleanup
@tracyboehrer, we replaced the |
@tracyboehrer, we updated this branch too and the build passed! |
tracyboehrer
approved these changes
Mar 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #908
Description
Implements BlobsStorage class and its unit tests. This PR also fixes a few disparities with C# present in different classes. Also, it's improving the parity C# - Java adding last changes of the repository.
Specific Changes
pom.xml
BlobsStorage
classBlobsTranscriptStore
classTranscriptStoreTests
unit testsBlobsStorageTests
unit testsTestPocoState
modelGenerateAnswerUtils
classNanoClockHelper
to have a timeStamp with nanoseconds (Java 8 has only milliseconds)Testing
BlobsStorageTests unit tests correctly passing
TranscriptStoreTests unit tests correctly passing
mvn clean install of the entire solution