Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: Fix CVE-2021-26701 (#5355) #1595

Closed
github-actions bot opened this issue Mar 25, 2021 · 1 comment
Closed

port: Fix CVE-2021-26701 (#5355) #1595

github-actions bot opened this issue Mar 25, 2021 · 1 comment
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.

Comments

@github-actions
Copy link

The changes in Fix CVE-2021-26701 (#5355) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Refs https://github.com/dotnet/runtime/issues/49377#affected-software

Fixes #5356

Description

System.Text.Encodings.Web has security issues needs to be fixed.

Most of our libraries don't directly depend on this particular package, in most cases, we depend on it via asp.net core. And after .net core 3.0, the asp.net core is built-into .net core runtime, so usually user just have to update the .net core runtime in their end, we should be OK.

One exception is in this particular package, we depend on "Microsoft.ApplicationInsights.AspNetCore" and then later depend on this offending package via package reference, which can't be solved by updating runtime.

So, in this fix, i override the transient dependency directly.

See also microsoft/BotFramework-Composer#6548

After the fix
image

Please review and, if necessary, port the changes.

@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Mar 25, 2021
@tracyboehrer
Copy link
Member

NA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Development

No branches or pull requests

1 participant