Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: security checks #6548

Merged
merged 9 commits into from
Mar 25, 2021
Merged

fix: security checks #6548

merged 9 commits into from
Mar 25, 2021

Conversation

boydc2014
Copy link
Contributor

@boydc2014 boydc2014 commented Mar 25, 2021

Task #minor

To fix the security check

  • Set our ci dotnet SDK to 3.1. Our UseDotNet action actually never worked because we are using the "runtime", which only allows application to run but not build. What we need is "sdk" to be able to build the solution.
  • Remove .net core 2.0 dependency, this would solve the most cases of of dependencies to asp.net core package in nuget, since starting from .net core 3.0, asp.net core is referred by "framework references" instead of the previous package references.
  • Explicit set system.text.encodings.web, because even though in step 2, we removed everything in .net core 2.0, we still have one dependency "Microsoft.Bot.Builder.Integration.ApplicationInsights.Core" that have transient dependency to nuget packages.

@coveralls
Copy link

coveralls commented Mar 25, 2021

Coverage Status

Coverage remained the same at 52.322% when pulling 4e8f10b on donglei/fix-pipeline into 231a8b9 on main.

@boydc2014 boydc2014 changed the title fix: Update azure-pipelines.yml to use SDK instead of runtime fix: security checks Mar 25, 2021
@cwhitten cwhitten merged commit ef525a6 into main Mar 25, 2021
@cwhitten cwhitten deleted the donglei/fix-pipeline branch March 25, 2021 18:41
@cwhitten cwhitten mentioned this pull request May 20, 2021
lei9444 added a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* fix: Update azure-pipelines.yml to use SDK instead of runtime

* Update Microsoft.BotFramework.Composer.Core.csproj

* Update Microsoft.BotFramework.Composer.Functions.csproj

* update system.Encodings.web

* Update Microsoft.BotFramework.Composer.Functions.csproj

Co-authored-by: leileizhang <[email protected]>
Co-authored-by: Soroush <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants