Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flask Application Insights Sample #193

Merged
merged 6 commits into from
Jun 25, 2019
Merged

Flask Application Insights Sample #193

merged 6 commits into from
Jun 25, 2019

Conversation

daveta
Copy link
Contributor

@daveta daveta commented May 30, 2019

Creates a Flask + Application Insights sample based on Core-Bot

In particular:

  • Flask Middleware to perform post-body caching.
  • Fixes Application Insights Telemetry Processor. Add explicit return values for filtering, and add better documentation.
  • Removed some dead code in Django Middleware that was converting POST body to Json object when it didn't need to.

stevengum
stevengum suggested changes Jun 5, 2019
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some small cleanup

samples/python-flask/21.corebot-app-insights/config.py Show resolved Hide resolved
samples/python-flask/21.corebot-app-insights/dialogs/cancel_and_help_dialog.py Show resolved Hide resolved
samples/python-flask/21.corebot-app-insights/dialogs/main_dialog.py Outdated Show resolved Hide resolved
samples/python-flask/21.corebot-app-insights/helpers/activity_helper.py Show resolved Hide resolved
@daveta daveta requested a review from stevengum June 24, 2019 19:51
stevengum
stevengum approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some nitpicks but once those are fixed it should be good to go.

libraries/botbuilder-applicationinsights/botbuilder/applicationinsights/django/__init__.py Outdated
@@ -1,5 +1,6 @@
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License.
"""Djanjo Application Insights package."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here, should be "Django"

...ilder-applicationinsights/botbuilder/applicationinsights/flask/flask_telemetry_middleware.py Outdated Show resolved Hide resolved
samples/python-flask/21.corebot-app-insights/dialogs/main_dialog.py Outdated Show resolved Hide resolved
...uilder-applicationinsights/botbuilder/applicationinsights/django/bot_telemetry_middleware.py Outdated Show resolved Hide resolved
@daveta daveta merged commit 10d8825 into master Jun 25, 2019
@daveta daveta deleted the daveta-appinsights-sample branch June 25, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@tsuwandy tsuwandy tsuwandy approved these changes

@axelsrz axelsrz Awaiting requested review from axelsrz

@CezaryMarcjan CezaryMarcjan Awaiting requested review from CezaryMarcjan

@munozemilio munozemilio Awaiting requested review from munozemilio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daveta @tsuwandy @stevengum