Ensure Connector Client is retrieved in teams_info.py #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
| @@ -318,10 +318,18 @@ def get_team_id(turn_context: TurnContext): | |||
|
|
|||
| @staticmethod | |||
| async def _get_connector_client(turn_context: TurnContext) -> ConnectorClient: | |||
| return await turn_context.adapter.create_connector_client( | |||
| turn_context.activity.service_url | |||
| if hasattr(turn_context.adapter, 'create_connector_client'): | |||
There was a problem hiding this comment.
I'm not convinced this is required. JS appears to take some streaming concerns into mind. Does this work with just getting the ConnectorClient from TurnState as DotNet does?
There was a problem hiding this comment.
Thanks. Indeed it does work with just getting the ConnectClient from TurnState.
Though, I encountered a failure in the test_on_teams_members_added_activity test case. To fix it, I implemented a mock ConnectorClient using the SimpleAdapter. What do you think?
tracyboehrer
approved these changes
Jan 26, 2024
bleu4422
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2061