Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axsuarez/corebot updates #249

Merged
merged 7 commits into from
Jul 11, 2019
Merged

Axsuarez/corebot updates #249

merged 7 commits into from
Jul 11, 2019

Conversation

axelsrz
Copy link
Member

@axelsrz axelsrz commented Jul 10, 2019

Parity changes in core-bot to match microsoft/BotBuilder-Samples#1570
Updates regarding samples testting will be pending.

Moved following classes from botbuilder.ai.luis to botbuilder.core to have parity with C#:

  • IntentScore
  • RecognizerResult
  • TopIntent

fixes #238

@axelsrz axelsrz requested a review from johnataylor July 10, 2019 23:49
@axelsrz axelsrz marked this pull request as ready for review July 10, 2019 23:49
@axelsrz axelsrz merged commit 0d7a680 into 4.5 Jul 11, 2019
@axelsrz axelsrz deleted the axsuarez/corebot-updates branch July 11, 2019 00:49
axelsrz added a commit that referenced this pull request Jul 11, 2019
@axelsrz axelsrz mentioned this pull request Jul 11, 2019
axelsrz added a commit that referenced this pull request Jul 11, 2019
* fix for accepting_input

* Axsuarez/corebot updates (#249)

* tests for pr #246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants