-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QnA Maker] Multi-turn support for python #305
Conversation
@trojenguri its build is failing on linting issues Please pip install
so that it'll auto-format your code to the repo's rules and also give you the linting errors that'll need to be fixed for the build to pass: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR! Excited for the multi-turn feature to be folded into the SDKs
Mostly just linting issues that need to be addressed. Also feel more comfortable if @axelsrz , our Python repo champion, takes a look at the PR as well.
libraries/botbuilder-ai/botbuilder/ai/qna/models/qna_request_context.py
Outdated
Show resolved
Hide resolved
libraries/botbuilder-ai/botbuilder/ai/qna/models/qna_request_context.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @trojenguri nice PR! I would like to merge this whenever @cleemullins takes the C# and JS ones.
libraries/botbuilder-ai/botbuilder/ai/qna/models/generate_answer_request_body.py
Show resolved
Hide resolved
libraries/botbuilder-ai/botbuilder/ai/qna/models/generate_answer_request_body.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please increase code coverage metrics.
libraries/botbuilder-ai/botbuilder/ai/qna/models/generate_answer_request_body.py
Outdated
Show resolved
Hide resolved
libraries/botbuilder-ai/botbuilder/ai/qna/models/qnamaker_trace_info.py
Outdated
Show resolved
Hide resolved
libraries/botbuilder-ai/botbuilder/ai/qna/models/generate_answer_request_body.py
Show resolved
Hide resolved
changes addressed
Multi-turn support for python