This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
Allow intent or entities using phraseList features of same name #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feich-ms
changed the title
|
Hi @munozemilio, this is the fix for issue #1051. Could you please take a look when you are convenient. Thanks. |
munozemilio
approved these changes
Jan 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1051. This PR is loosing the validation in lu ->json converter when intents or entities use phraseList features with same name. This is allowed in LUIS portal, but blocked in bf-lu. Also added the typical test cases for these scenarios.