Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

Fix expression visitor to make escape work in nested entity definition #1106

Merged
merged 2 commits into from
Feb 5, 2021

Conversation

feich-ms
Copy link
Contributor

@feich-ms feich-ms commented Feb 5, 2021

Closes #1107. Fix expression visitor logic to make escape work in nested entity definition, typical cases are:

# BoldIntent
- {@Command={@Action={@BoldAction=bold}} \{{@ActionTargetPhrase=directions from seattle to portland}\}},
- {@Command={@Action={@BoldAction=emphasise from}} {@ActionTargetRange={@ActionTargetStart=@username {@ActionTargetSeparator=through} {@ActionTargetEnd==}}}

After the fix, the escape brackets in nested brackets will work and the equal sign as entity value will also work.

@feich-ms feich-ms requested a review from munozemilio as a code owner February 5, 2021 06:28
@feich-ms feich-ms requested a review from boydc2014 February 5, 2021 06:28
@feich-ms feich-ms merged commit fe56306 into main Feb 5, 2021
@feich-ms feich-ms deleted the feich/FixExpressionLexer branch February 5, 2021 06:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escape brackets in nested entity definition not work
2 participants