This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
Replace node-fetch with axios to support using proxy #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boydc2014
reviewed
Apr 19, 2021
cosmicshuai
requested review from
cleemullins,
joshgummersall and
munozemilio
as code owners
joshgummersall
suggested changes
Apr 19, 2021
…t/botframework-cli into shuwan/replaceNodeFetch
joshgummersall
approved these changes
Apr 22, 2021
|
@munozemilio Hi, Emilio, could you help review this PR. It will unblock the proxy setting of orchestrator triggers in Composer. |
munozemilio
approved these changes
May 12, 2021
There was a problem hiding this comment.
Approved. @tsuwandy there are some changes to Orchestrator pieces FYI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all node-fetch with axios with capability to support https proxy.
Some tests on setting up proxy：
Qna Translate:
Luis Translate:
Chatdown convert:
LG translate:
Orchestrator base model download:
Orchestator base model list:
Luis build with import from blob storage:
