Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

Silent ci install #551

Merged
merged 7 commits into from
Feb 11, 2020
Merged

Silent ci install #551

merged 7 commits into from
Feb 11, 2020

Conversation

munozemilio
Copy link
Contributor

@munozemilio munozemilio commented Feb 7, 2020 •
edited
Loading

Fixes #517
Fixes #504

@munozemilio munozemilio requested a review from scheyal February 11, 2020 18:16
scheyal
scheyal approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@scheyal scheyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on double check.
Also, we need to document the behavior.

@munozemilio munozemilio merged commit fe3b112 into master Feb 11, 2020
@munozemilio munozemilio deleted the emimunoz/silent-ci-install branch February 13, 2020 00:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scheyal scheyal scheyal approved these changes

@christopheranderson christopheranderson Awaiting requested review from christopheranderson

@jspruance jspruance Awaiting requested review from jspruance

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@munozemilio @scheyal