-
Notifications
You must be signed in to change notification settings - Fork 129
[Lubuild] fix multiple bugs: case sensitive issue, default version issue and exception not throw out issue #576
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add tests as well?
@vishwacsena, sure, will add tests soon. |
Tests added @vishwacsena |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@munozemilio it might make sense to expose compareApps as a public method on LUIS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CIL
@munozemilio, comments resolved. Also added test cases for luConfig support of #548. Fixed bug of #582 as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments in line
Comments resolved. Thanks @munozemilio |
@feich-ms I tried this E2E and pushed up two sets of deltas up to your branch. I'm not familiar with nock and some of the lubuild tests are failing. Can you take a look and address? |
@munozemilio except for addressing tests, it would be good if you get a review as well. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CIL
@munozemilio, tests failures are fixed. Please help to approve. Thanks. The merge is blocked by 'Request to change'. Could you approve if there are no other issues. |
@munozemilio, I added more modules in index.js and composerindex.js in the latest commit. My intention is to expose modules that composer client/broswer consumes in composerindex.js and other modules in index.js. Parser and SectionHandler is consumed by composer client and luBuild is consumed by composer server. Please let me know if this is not the reasonable way. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a comment
Fix several bugs: