Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

Nigao/boolean #595

Merged
merged 9 commits into from
Feb 24, 2020
Merged

Nigao/boolean #595

merged 9 commits into from
Feb 24, 2020

Conversation

ninggao
Copy link
Contributor

@ninggao ninggao commented Feb 21, 2020

No description provided.

@ninggao ninggao requested a review from chrimc62 February 21, 2020 19:31

# callSetMessage
- @\{setPropertyMessage('@{property}', @boolean)}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect we could inline this now if we wanted to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make a separate PR since this change may involve all .dialog files.

- @{entityLUFilename()}

# template
- $@{property}Entity:boolean
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$@{property}Entity:boolean [](start = 2, length = 26)

I'm a little fuzzy on why we need this and it appears to be in the old syntax.

Copy link
Contributor Author

@ninggao ninggao Feb 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to new syntax.


# template
- @{AskTemplate()}\n@{NameTemplate()}\n@{ValueTemplate()}\n\[@{schemaName}-@{property}Entity.@{locale}.lg]\n\[library.lg]\n\[library-Missing.lg]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multi-line with ```

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

- ```
@{askHelp()}
Enter a value for @{name(property)}: true or false
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a little weird for all done?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ask is only triggered when a property's type is Boolean, and it's included in requiredProperties. CompleteConfirmation shouldn't be added to the requiredProperties list, so this Ask should never be triggered.

Copy link
Contributor

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@ninggao ninggao requested a review from chrimc62 February 24, 2020 19:43
Copy link
Contributor

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ninggao ninggao merged commit b28cf40 into master Feb 24, 2020
@ninggao ninggao deleted the nigao/boolean branch February 24, 2020 21:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants