Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fatal issues with Azure deployment templates #513

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Fix fatal issues with Azure deployment templates #513

merged 3 commits into from
Oct 17, 2023

Conversation

glahaye
Copy link
Contributor

@glahaye glahaye commented Oct 16, 2023

Motivation and Context

Current Azure ARM template is not functional

Description

  • Remove embedding storage methods no longer support (Volatile and PostGres)
  • Merge the 3 app insights into 1
  • Have a single switch for whether to deploy binary packages
  • Remove obsolete MemoryStore app settings
  • Add Qdrant settings to SemanticMemory:Services
  • Add memory pipeline service to Qdrant vnet

Contribution Checklist

@glahaye glahaye requested review from TaoChenOSU and alliscode and removed request for TaoChenOSU October 16, 2023 23:47
@github-actions github-actions bot added the deployment Issues related to deploying Chat-Copilot label Oct 16, 2023
@glahaye glahaye self-assigned this Oct 16, 2023
@glahaye glahaye added the bug Something isn't working label Oct 16, 2023
TaoChenOSU
TaoChenOSU previously approved these changes Oct 17, 2023
scripts/deploy/deploy-azure.ps1 Outdated Show resolved Hide resolved
@TaoChenOSU
Copy link
Contributor

TaoChenOSU commented Oct 17, 2023

This PR addresses: #510

alliscode
alliscode previously approved these changes Oct 17, 2023
scripts/deploy/deploy-azure.ps1 Outdated Show resolved Hide resolved
@glahaye glahaye added this pull request to the merge queue Oct 17, 2023
Merged via the queue into microsoft:main with commit 89d025f Oct 17, 2023
@glahaye glahaye deleted the bicep-fixes branch October 17, 2023 17:42
@victor-v-rad
Copy link

@glahaye @TaoChenOSU
Please fix OpenAI Deployment as well
#516

Ryangr0 pushed a commit to webgrip/chat-copilot that referenced this pull request Oct 26, 2023
### Motivation and Context
Current Azure ARM template is not functional

### Description
- Remove embedding storage methods no longer support (Volatile and
PostGres)
- Merge the 3 app insights into 1
- Have a single switch for whether to deploy binary packages
- Remove obsolete MemoryStore app settings
- Add Qdrant settings to SemanticMemory:Services
- Add memory pipeline service to Qdrant vnet

### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this pull request Oct 7, 2024
### Motivation and Context
Current Azure ARM template is not functional

### Description
- Remove embedding storage methods no longer support (Volatile and
PostGres)
- Merge the 3 app insights into 1
- Have a single switch for whether to deploy binary packages
- Remove obsolete MemoryStore app settings
- Add Qdrant settings to SemanticMemory:Services
- Add memory pipeline service to Qdrant vnet

### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
kb0039 pushed a commit to aaronba/chat-copilot that referenced this pull request Jan 8, 2025
### Motivation and Context
Current Azure ARM template is not functional

### Description
- Remove embedding storage methods no longer support (Volatile and
PostGres)
- Merge the 3 app insights into 1
- Have a single switch for whether to deploy binary packages
- Remove obsolete MemoryStore app settings
- Add Qdrant settings to SemanticMemory:Services
- Add memory pipeline service to Qdrant vnet

### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deployment Issues related to deploying Chat-Copilot
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

5 participants