Fix race condition in bicep / ARM template #564
Merged
+31
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glahaye
commented
Nov 1, 2023
glahaye
commented
Nov 1, 2023
glahaye
commented
Nov 1, 2023
teresaqhoang
approved these changes
Nov 2, 2023
alliscode
approved these changes
Nov 2, 2023
|
I see this PR has been merged, but I am still getting the same race error using ARM "Deploy to Azure" option. I am pointing to:
Are these URIs updated w/ the latest fix? Edit: just tried deploying via deploy-azure.ps1 and get the same error. Seems specific to: memorypipeline/MSDeploy |
The URLs are fine. Can you provide your error in #539 ? And you are positive you pulled the latest code before running your deployment, right? I might have to take another look at this problem! |
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
### Motivation and Context Without this change, virtually all deployments will fail when deploying some of the extensions (MSDeploy or App Insights) for our services. ### Description - Make each service has its own virtualNetworkConnections resource - Add dependsOn clause for the service extensions on their respective virtualNetworkConnections resource - Remove some crud that had accumulated in the template files - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations
kb0039
pushed a commit
to aaronba/chat-copilot
that referenced
this pull request
Jan 8, 2025
### Motivation and Context Without this change, virtually all deployments will fail when deploying some of the extensions (MSDeploy or App Insights) for our services. ### Description - Make each service has its own virtualNetworkConnections resource - Add dependsOn clause for the service extensions on their respective virtualNetworkConnections resource - Remove some crud that had accumulated in the template files - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Without this change, virtually all deployments will fail when deploying some of the extensions (MSDeploy or App Insights) for our services.
Description
Make each service has its own virtualNetworkConnections resource
Add dependsOn clause for the service extensions on their respective virtualNetworkConnections resource
Remove some crud that had accumulated in the template files
The code builds clean without any errors or warnings
The PR follows the Contribution Guidelines and the pre-submission formatting script raises no violations