Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IHttpClientFactory #578

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Use IHttpClientFactory #578

merged 2 commits into from
Nov 7, 2023

Conversation

glahaye
Copy link
Contributor

@glahaye glahaye commented Nov 7, 2023

Motivation and Context

To reduce the latency between for requests, we can re-use connections.

Description

Use IHttpClientFactory to pool and re-use underlying HttpClientMessageHandler instances.

Contribution Checklist

@github-actions github-actions bot added the webapi Pull requests that update .net code label Nov 7, 2023
@glahaye glahaye self-assigned this Nov 7, 2023
@glahaye glahaye linked an issue Nov 7, 2023 that may be closed by this pull request
@glahaye glahaye added this pull request to the merge queue Nov 7, 2023
Merged via the queue into microsoft:main with commit 342a928 Nov 7, 2023
@glahaye glahaye deleted the ihttpclientfactory branch November 7, 2023 21:27
teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this pull request Oct 7, 2024
### Motivation and Context
To reduce the latency between for requests, we can re-use connections.

### Description
Use IHttpClientFactory to pool and re-use underlying
HttpClientMessageHandler instances.

### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
kb0039 pushed a commit to aaronba/chat-copilot that referenced this pull request Jan 8, 2025
### Motivation and Context
To reduce the latency between for requests, we can re-use connections.

### Description
Use IHttpClientFactory to pool and re-use underlying
HttpClientMessageHandler instances.

### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
webapi Pull requests that update .net code
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Proper use and reuse of HttpClient / IHttpClientFactory
2 participants