Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remnants of memory migration #823

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Remove remnants of memory migration #823

merged 2 commits into from
Feb 28, 2024

Conversation

glahaye
Copy link
Contributor

@glahaye glahaye commented Feb 27, 2024

Motivation and Context

Memory migration has been removed but some of its code was still present.

Description

Remove leftover memory migration code

Contribution Checklist

@glahaye glahaye requested a review from crickman February 27, 2024 20:41
@glahaye glahaye self-assigned this Feb 27, 2024
@github-actions github-actions bot added the webapi Pull requests that update .net code label Feb 27, 2024
@glahaye glahaye added the enhancement New feature or request label Feb 27, 2024
@glahaye glahaye added this pull request to the merge queue Feb 28, 2024
Merged via the queue into microsoft:main with commit 4559fce Feb 28, 2024
7 checks passed
@glahaye glahaye deleted the remove_mem_migration_remnants branch February 28, 2024 17:39
teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this pull request Oct 7, 2024
### Motivation and Context
Memory migration has been removed but some of its code was still
present.

### Description
Remove leftover memory migration code

### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
kb0039 pushed a commit to aaronba/chat-copilot that referenced this pull request Jan 8, 2025
### Motivation and Context
Memory migration has been removed but some of its code was still
present.

### Description
Remove leftover memory migration code

### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request webapi Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants