Respect order, number to skip and number to take of chat messages at underlying DB level rather than higher #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0b586b8.
…underlying DB level rather than at higher service level
github-actions
bot
added
webapp
crickman
approved these changes
Mar 27, 2024
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
…underlying DB level rather than higher (microsoft#902) ### Motivation and Context As described in microsoft#718, we load ALL the messages from ALL of the chats of the user in the frontend at log in. Also, no matter how many messages we want, we read them ALL at the DB level and then throw some away if the number read is too higher at the service level. ### Description Now, with this change, we actually respect the order, the number to skip and the number to take of chat messages at the underlying DB level rather than at higher service level. This enables us to save some DB activity and make our queries from the frontend eventually a lot tighter, This change was made in a simple manner which doesn't change the underlying architecture. ### Contribution Checklist - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
kb0039
pushed a commit
to aaronba/chat-copilot
that referenced
this pull request
Jan 8, 2025
…underlying DB level rather than higher (microsoft#902) ### Motivation and Context As described in microsoft#718, we load ALL the messages from ALL of the chats of the user in the frontend at log in. Also, no matter how many messages we want, we read them ALL at the DB level and then throw some away if the number read is too higher at the service level. ### Description Now, with this change, we actually respect the order, the number to skip and the number to take of chat messages at the underlying DB level rather than at higher service level. This enables us to save some DB activity and make our queries from the frontend eventually a lot tighter, This change was made in a simple manner which doesn't change the underlying architecture. ### Contribution Checklist - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
As described in #718, we load ALL the messages from ALL of the chats of the user in the frontend at log in.
Also, no matter how many messages we want, we read them ALL at the DB level and then throw some away if the number read is too higher at the service level.
Description
Now, with this change, we actually respect the order, the number to skip and the number to take of chat messages at the underlying DB level rather than at higher service level.
This enables us to save some DB activity and make our queries from the frontend eventually a lot tighter,
This change was made in a simple manner which doesn't change the underlying architecture.
Contribution Checklist