Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go With Replace Detector no File Parsing #1181

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Conversation

amitla1
Copy link
Contributor

@amitla1 amitla1 commented Jun 18, 2024

Remove the file parsing for the replace section of the file
The current go detector and the new go detector that has the replace module sometimes detect a different number of components and they should be the same number. The file parsing logic that was changed in the new go detector couldve impacted this therefore reverting that change and just implementing replace logic for CLI and not parsing a file

@amitla1 amitla1 requested a review from a team as a code owner June 18, 2024 01:05
@amitla1 amitla1 requested a review from daniel-akili June 18, 2024 01:05
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.2%. Comparing base (dafe527) to head (4d84159).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1181     +/-   ##
=======================================
- Coverage   76.3%   76.2%   -0.1%     
=======================================
  Files        257     257             
  Lines      11495   11440     -55     
  Branches    1156    1147      -9     
=======================================
- Hits        8772    8723     -49     
  Misses      2384    2384             
+ Partials     339     333      -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 19, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@amitla1 amitla1 merged commit 2284e06 into main Jun 19, 2024
26 checks passed
@amitla1 amitla1 deleted the users/avannikumar/GoDetector branch June 19, 2024 22:11
@cobya cobya mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants