Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote NuGet detector experiment to primary detector #1337

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Jan 8, 2025

Promote NuGetPackageReferenceFrameworkAware experimental detector to primary detector NuGetProjectCentric.

@ericstj ericstj requested a review from grvillic January 8, 2025 18:51
@ericstj ericstj requested a review from a team as a code owner January 8, 2025 18:51
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 94.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.6%. Comparing base (fae54ba) to head (851fe0f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...uGetProjectModelProjectCentricComponentDetector.cs 84.9% 3 Missing and 5 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1337     +/-   ##
=======================================
- Coverage   89.7%   89.6%   -0.2%     
=======================================
  Files        387     384      -3     
  Lines      30473   29930    -543     
  Branches    1894    1835     -59     
=======================================
- Hits       27362   26843    -519     
+ Misses      2713    2696     -17     
+ Partials     398     391      -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericstj
Copy link
Member Author

ericstj commented Jan 9, 2025

I think the "verify snapshot" tests are failing because they are observing the increase in detected components due to reporting of development dependencies.

@grvillic grvillic merged commit 7e82752 into microsoft:main Jan 15, 2025
20 of 23 checks passed
Copy link

github-actions bot commented Jan 15, 2025

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants