Skip to content

Commit

Permalink
bug fixes and under the hood enhancements
Browse files Browse the repository at this point in the history
  • Loading branch information
prdpsvs committed Dec 14, 2023
1 parent b5afb8d commit 09cc2a0
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release-version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
steps:
- uses: actions/checkout@v4

- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: '3.9'

Expand Down
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
# Changelog

### v1.7.2

## Bug Fixes
* Addressed issue [#53](https://github.com/microsoft/dbt-fabric/issues/101) - "The server supports a maximum of 2100 parameters" by reducing the batch size by 1 if number of insert value parameters exceed 2100.
* Added bytearry data type code support along bytes for varbinary sql datatype.

## Enhancements
* Bump dbt-tests-adapter requirement from ~=1.7.2 to ~=1.7.3
* Bump pre-commit from 3.5.0 to 3.6.0
* Bump actions/setup-python from 4 to 5

### v1.7.1

## Features
Expand Down
2 changes: 1 addition & 1 deletion dbt/adapters/fabric/__version__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
version = "1.7.1"
version = "1.7.2"
1 change: 1 addition & 0 deletions dbt/adapters/fabric/fabric_connection_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
# "int": "tinyint",
"int": "int",
"bytes": "varbinary",
"bytearray": "varbinary",
"bool": "bit",
"datetime.date": "date",
"datetime.datetime": "datetime2(6)",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
reduce the batch size so it fits.
#}
{% set max_batch_size = get_batch_size() %}
{% set calculated_batch = (2100 / num_columns)|int %}
{% set calculated_batch = (2100 / num_columns)-1|int %}
{% set batch_size = [max_batch_size, calculated_batch] | min %}

{{ return(batch_size) }}
Expand Down
4 changes: 2 additions & 2 deletions dev_requirements.txt
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
pytest==7.4.3
twine==4.0.2
wheel==0.42
pre-commit==3.5.0
pre-commit==3.6.0
pytest-dotenv==0.5.2
dbt-tests-adapter~=1.7.2
dbt-tests-adapter~=1.7.3
flaky==3.7.0
pytest-xdist==3.5.0
-e .

0 comments on commit 09cc2a0

Please sign in to comment.