Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure attach binaries are built before running tox #1753

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

rchiodo
Copy link
Contributor

@rchiodo rchiodo commented Dec 3, 2024

Our contributing.MD doesn't mention how to make the attach binaries. This makes them just build as part of running tox.

@rchiodo rchiodo requested a review from a team as a code owner December 3, 2024 21:36
@rchiodo
Copy link
Contributor Author

rchiodo commented Dec 3, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rchiodo
Copy link
Contributor Author

rchiodo commented Dec 3, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rchiodo rchiodo merged commit 43f4102 into microsoft:main Dec 3, 2024
22 of 24 checks passed
@rchiodo rchiodo deleted the rchiodo/attach_binaries branch December 3, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants