Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH widget does not show hosts with multi-word alias names #2646

Closed
gohellp opened this issue Apr 17, 2024 · 3 comments · Fixed by #2664
Closed

SSH widget does not show hosts with multi-word alias names #2646

gohellp opened this issue Apr 17, 2024 · 3 comments · Fixed by #2664
Labels
Area-Widgets Related to in-package widgets Issue-Bug Something isn't working or needs investigation Priority-2 Resolution-Fix-Available Available in a release Widget-SSH-Keychain Pertains to the SSH Keychain widget
Milestone

Comments

@gohellp
Copy link
Contributor

gohellp commented Apr 17, 2024

Dev Home version

0.1201.442.0

Windows build number

10.0.22631.3447

Other software

OS Build Version: 10.0.22631.3447.amd64fre.ni_release.220506-1250
.NET Version: .NET 8.0.1

Steps to reproduce the bug

  1. Point the SSH widget to a config file where one of the hosts has a multi-word alias name
  2. See that that host is not shown in the list

Expected result

The presence of the new configuration in the list

Actual result

The application ignores the configuration

Included System Information

CPU: AMD Ryzen 5 3600 6-Core Processor
Physical Memory: 63.92GB (49.35GB free)
Processor Architecture: x64

Included Extensions Information

Extensions:
Microsoft.Windows.DevHome_0.1201.442.0_x64__8wekyb3d8bbwe
Microsoft.Windows.DevHome_0.1201.442.0_x64__8wekyb3d8bbwe
Microsoft.Windows.DevHomeGitHubExtension_0.1200.442.0_x64__8wekyb3d8bbwe
Microsoft.DevHomeMicrosoftGameDevExtension_0.400.456.0_x64__8wekyb3d8bbwe

Widget Service:
MicrosoftWindows.Client.WebExperience_424.1301.450.0_x64__cw5n1h2txyewy

@gohellp gohellp added the Issue-Bug Something isn't working or needs investigation label Apr 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label Apr 17, 2024
@krschau
Copy link
Collaborator

krschau commented Apr 17, 2024

@gohellp This issue was a little vague, so I'm going to re-word it. If you actually meant something else, please let me know.

@krschau krschau changed the title ssh config miniapp ignore record with multiple hosts SSH widget does not reflect changes to the content of the configured config file Apr 17, 2024
@krschau krschau added Area-Widgets Related to in-package widgets Priority-2 and removed Needs-Triage New issue that the core contributors need to triage labels Apr 17, 2024
@gohellp
Copy link
Contributor Author

gohellp commented Apr 17, 2024

@gohellp This issue was a little vague, so I'm going to re-word it. If you actually meant something else, please let me know.

Widget ignore record with multiple host aliases. I wrote this config:

Host hshp-vps
    Hostname server_ip
    User gohellp
    IdentityFile ~/.ssh/id_rsa_hshp-vps

Host router openwrt
    Hostname 192.168.1.1
    User root
    IdentityFile ~/.ssh/id_rsa_home-router

And widget ignore router/openwrt record.
image

gohellp added a commit to gohellp/devhome that referenced this issue Apr 17, 2024
@krschau
Copy link
Collaborator

krschau commented Apr 18, 2024

I understand now. From your fix, it seems the issue was one word after host vs multiple. I opened #2672 for what I thought you meant originally, and I'll update this one again.

@krschau krschau changed the title SSH widget does not reflect changes to the content of the configured config file SSH widget does not show hosts with multi-word alias names Apr 18, 2024
@krschau krschau added the Widget-SSH-Keychain Pertains to the SSH Keychain widget label Apr 19, 2024
@krschau krschau added this to the Dev Home 0.15 milestone Jun 7, 2024
@krschau krschau added the Resolution-Fix-Committed Fix is checked in, but may take 3-4 weeks before it's in a release label Jun 7, 2024
@krschau krschau added Resolution-Fix-Available Available in a release and removed Resolution-Fix-Committed Fix is checked in, but may take 3-4 weeks before it's in a release labels Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Widgets Related to in-package widgets Issue-Bug Something isn't working or needs investigation Priority-2 Resolution-Fix-Available Available in a release Widget-SSH-Keychain Pertains to the SSH Keychain widget
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants