Disallow user from adding widgets if the WidgetService isn't started #3632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricJohnson327
approved these changes
Aug 16, 2024
dkbennett
approved these changes
Aug 16, 2024
EricJohnson327
pushed a commit
that referenced
this pull request
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
If the WidgetService can't start, then we shouldn't let the user try to add widgets. Instead of checking a variable
HasWidgetService, change it toHasWidgetServiceInitializedwhich only is true if actual calls to the WidgetService have succeeded.Also fix the logging on some errors.
References and relevant issues
Mitigates #3594
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist