Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove What's New page #3952

Merged
merged 1 commit into from
Oct 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion common/Services/INavigationService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ public static class KnownPageKeys
{
public static readonly string Dashboard = "DevHome.Dashboard.ViewModels.DashboardViewModel";
public static readonly string Extensions = "DevHome.ExtensionLibrary.ViewModels.ExtensionLibraryViewModel";
public static readonly string WhatsNew = "DevHome.ViewModels.WhatsNewViewModel";
public static readonly string Settings = "DevHome.Settings.ViewModels.SettingsViewModel";
public static readonly string Feedback = "DevHome.Settings.ViewModels.FeedbackViewModel";
public static readonly string Environments = "DevHome.Environments.ViewModels.LandingPageViewModel";
Expand Down
4 changes: 1 addition & 3 deletions common/TelemetryEvents/DeveloperId/EntryPointEvent.cs
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,14 @@ public enum EntryPoint
None = 0,
Settings = 1,
SetupFlow = 2,
WhatsNewPage = 3,
Widget = 4,
Widget = 3,
}

private readonly string[] _entryPointNames =
[
string.Empty,
"Settings",
"SetupFlow",
"WhatsNewPage",
"Widget",
];

Expand Down
1 change: 0 additions & 1 deletion src/App.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ public App()
services.AddTransient<ShellPage>();
services.AddTransient<InitializationPage>();
services.AddTransient<ShellViewModel>();
services.AddTransient<WhatsNewViewModel>();
services.AddTransient<InitializationViewModel>();

// Settings
Expand Down
Binary file removed src/Assets/WhatsNewPage/DarkTheme/Background.png
Binary file not shown.
Binary file removed src/Assets/WhatsNewPage/DarkTheme/DashboardHero.png
Binary file not shown.
Binary file not shown.
Binary file removed src/Assets/WhatsNewPage/DarkTheme/DevIdHero.png
Binary file not shown.
Binary file removed src/Assets/WhatsNewPage/DarkTheme/Extensions.png
Binary file not shown.
Binary file removed src/Assets/WhatsNewPage/DarkTheme/ExtensionsBig.png
Binary file not shown.
Binary file removed src/Assets/WhatsNewPage/LightTheme/Background.png
Binary file not shown.
Binary file not shown.
Binary file removed src/Assets/WhatsNewPage/LightTheme/DevDriveHero.png
Binary file not shown.
Binary file removed src/Assets/WhatsNewPage/LightTheme/DevIdHero.png
Binary file not shown.
Binary file removed src/Assets/WhatsNewPage/LightTheme/Extensions.png
Binary file not shown.
Binary file not shown.
4 changes: 0 additions & 4 deletions src/DevHome.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,6 @@
</ItemGroup>

<ItemGroup>
<None Remove="Assets\WhatsNewPage\DarkTheme\Extensions.png" />
<None Remove="Assets\WhatsNewPage\DarkTheme\ExtensionsBig.png" />
<None Remove="Assets\WhatsNewPage\LightTheme\Extensions.png" />
<None Remove="Assets\WhatsNewPage\LightTheme\ExtensionsBig.png" />
<None Remove="Styles\HyperlinkButton.xaml" />
<None Remove="Styles\WindowTitleBar_ThemeResources.xaml" />
</ItemGroup>
Expand Down
88 changes: 0 additions & 88 deletions src/Models/WhatsNewCard.cs

This file was deleted.

1 change: 0 additions & 1 deletion src/Services/PageService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ where assembly.GetName().Name == tool.Assembly
this.ConfigureCustomizationPages();

// Configure footer pages
Configure<WhatsNewViewModel, WhatsNewPage>();
this.ConfigureExtensionLibraryPages();
this.ConfigureSettingsPages();

Expand Down
63 changes: 0 additions & 63 deletions src/Strings/en-us/Resources.resw
Original file line number Diff line number Diff line change
Expand Up @@ -129,36 +129,6 @@
<value>All files</value>
<comment>Text for a dropdown option in a file picker dialog to show all files in a directory</comment>
</data>
<data name="WhatsNewPage_DevIdCard.Description" xml:space="preserve">
<value>After you install an extension that connects one of your developer accounts to Dev Home, sign in to that account.</value>
</data>
<data name="WhatsNew.Content" xml:space="preserve">
<value>Introducing Dev Home</value>
</data>
<data name="WhatsNewPage_DevDriveCard.Description" xml:space="preserve">
<value>Optimize performance with a Dev Drive—Dev Home sets it up for you.</value>
</data>
<data name="WhatsNewPage_DevDriveCard.Title" xml:space="preserve">
<value>Create a Dev Drive</value>
</data>
<data name="WhatsNewPage_Description.Text" xml:space="preserve">
<value>Set up your machine, monitor your workflows, and access development utilities all from one centralized location.</value>
</data>
<data name="WhatsNewPage_DevDashCard.Description" xml:space="preserve">
<value>Get the info you need in one place—add widgets to track issues, pull requests, and system performance.</value>
</data>
<data name="WhatsNewPage_DevDashCard.Title" xml:space="preserve">
<value>Monitor projects in your dashboard</value>
</data>
<data name="WhatsNewPage_DevIdCard.Title" xml:space="preserve">
<value>Connect your developer account</value>
</data>
<data name="WhatsNewPage_NotifCard.Description" xml:space="preserve">
<value>Keep up with pull requests, checks, merges, and more.</value>
</data>
<data name="WhatsNewPage_NotifCard.Title" xml:space="preserve">
<value>Get timely notifications</value>
</data>
<data name="InitializationPage_InfoDescription.Text" xml:space="preserve">
<value>Monitor and track your coding tasks, workflows, system performance, and more on a customizable dashboard.</value>
</data>
Expand All @@ -180,9 +150,6 @@
<data name="InitializationPage_Title.Text" xml:space="preserve">
<value>Dev Home is getting things ready for you...</value>
</data>
<data name="WhatsNewPage_Title.Text" xml:space="preserve">
<value>Your development control center</value>
</data>
<data name="Feedback_Title.Text" xml:space="preserve">
<value>Feedback</value>
</data>
Expand All @@ -192,24 +159,6 @@
<data name="AppDisplayNameStable" xml:space="preserve">
<value>Dev Home (Preview)</value>
</data>
<data name="WhatsNewPage_DevDashCard.ButtonText" xml:space="preserve">
<value>Pin widgets</value>
</data>
<data name="WhatsNewPage_DevDriveCard.ButtonText" xml:space="preserve">
<value>Create Dev Drive</value>
</data>
<data name="WhatsNewPage_DevDriveCard.Link" xml:space="preserve">
<value>Learn more</value>
</data>
<data name="WhatsNewPage_DevIdCard.ButtonText" xml:space="preserve">
<value>Connect accounts</value>
</data>
<data name="WhatsNewPage_GetStartedButton.Content" xml:space="preserve">
<value>Get started</value>
</data>
<data name="WhatsNewPage_Header.Text" xml:space="preserve">
<value>Introducing Dev Home</value>
</data>
<data name="WidgetProviderDisplayNameDev" xml:space="preserve">
<value>Dev Home (Dev)</value>
<comment>The display name for core widgets provider</comment>
Expand All @@ -234,18 +183,6 @@
<value>Administrator: Dev Home (Preview)</value>
<comment>Name of app when run as administrator</comment>
</data>
<data name="WhatsNewPage_ExtensionsCard.ButtonText" xml:space="preserve">
<value>Explore extensions</value>
<comment>Button text on extensions card on "whats new" page</comment>
</data>
<data name="WhatsNewPage_ExtensionsCard.Description" xml:space="preserve">
<value>Extensions help you get more out of Dev Home. For example, get recommendations for other repositories to add when setting up your machine in Dev Home and add other widgets to your dashboard.</value>
<comment>Description of extensions card on "whats new" page</comment>
</data>
<data name="WhatsNewPage_ExtensionsCard.Title" xml:space="preserve">
<value>Explore Dev Home extensions</value>
<comment>Title of extensions card on "whats new" page</comment>
</data>
<data name="WidgetDisplayNameCPU" xml:space="preserve">
<value>CPU</value>
<comment>Short name for the machine's Central Processing Unit.</comment>
Expand Down
5 changes: 2 additions & 3 deletions src/ViewModels/ShellViewModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public ShellViewModel(
screenReaderService.AnnouncementTextChanged += OnAnnouncementTextChanged;
}

public async Task OnLoaded()
public void OnLoaded()
{
var activationKind = AppInstance.GetCurrent().GetActivatedEventArgs().Kind;
Log.Information($"Activated with kind {activationKind}");
Expand All @@ -68,8 +68,7 @@ public async Task OnLoaded()
break;
case ExtendedActivationKind.Launch:
default:
var isNotFirstRun = await _localSettingsService.ReadSettingAsync<bool>(WellKnownSettingsKeys.IsNotFirstRun);
NavigationService.NavigateTo(isNotFirstRun ? NavigationService.DefaultPage : typeof(WhatsNewViewModel).FullName!);
NavigationService.NavigateTo(NavigationService.DefaultPage);
break;
}
}
Expand Down
119 changes: 0 additions & 119 deletions src/ViewModels/WhatsNewViewModel.cs

This file was deleted.

6 changes: 0 additions & 6 deletions src/Views/ShellPage.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,6 @@
<NavigationViewItem x:Uid="Shell_IGNORE" helpers:NavigationHelper.NavigateTo="DevHome.Settings.ViewModels.SettingsViewModel" Visibility="Collapsed"/>
</NavigationView.MenuItems>
<NavigationView.FooterMenuItems>
<NavigationViewItem x:Uid="WhatsNew" AutomationProperties.AutomationId="WhatsNew"
helpers:NavigationHelper.NavigateTo="DevHome.ViewModels.WhatsNewViewModel">
<NavigationViewItem.Icon>
<FontIcon FontFamily="{StaticResource SymbolThemeFontFamily}" Glyph="&#xE789;"/>
</NavigationViewItem.Icon>
</NavigationViewItem>
<NavigationViewItem x:Uid="ms-resource:///DevHome.ExtensionLibrary/Resources/NavigationPane" AutomationProperties.AutomationId="Extensions"
helpers:NavigationHelper.NavigateTo="DevHome.ExtensionLibrary.ViewModels.ExtensionLibraryViewModel">
<NavigationViewItem.Icon>
Expand Down
Loading
Loading