This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Always use tslint@latest to list; have expect rule handle checking with an older TypeScript version
#40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with an older TypeScript version
ghost
requested a review
from 
|
@andy-ms, |
ghost
commented
May 27, 2017
| @@ -1,8 +1,5 @@ | |||
| { | |||
| "rulesDirectory": ["../../bin/rules"], | |||
| "linterOptions": { | |||
There was a problem hiding this comment.
tslint doesn't need this any more, now it needs a tsconfig.json to be present. palantir/tslint#2769
ghost
mentioned this pull request
8 tasks
sandersn
approved these changes
May 30, 2017
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39
I was unable to get this working in a unit test because tslint's tests use
.ts.lintfiles that aren't picked up in TypeScript by default. Ideally we could just copy the old program but microsoft/TypeScript#15344 was causing bugs when I tried that. Instead I have acreateProgramfunction based on tslint's the re-parses the config. I've tested that this works on DefinitelyTyped.