Add an exception for xmlns usage, and add appropriate testing #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't assign this, but pinging @A-Katopodis for code review |
A-Katopodis
reviewed
May 11, 2021
|
Hi @HarryGwinnell, Thanks for the contribution! Left one comment but everything else looks good. |
A-Katopodis
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #10 to allow any namespace to be used in an xmlns attribute. Unfortunately most XML namespaces use http:// as prefixes, even though these urls are never resolved (and are often not valid addresses anyway).
As this issue only presents in React implementations, I've added a new parserOptions to simulate a typescript/react setup (mirroring our use case). This included adding a tsconfig with jsx enabled, and a blank estree.tsx.
I've added a sample valid & invalid test case using SVGs, but this should hold true for any XML that is used.