fix: a race condition in Host.resetAllServices #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a race condition in Host.resetAllServices() caused by calling channel.close() as a callback of grpc.Client.waitForReady(). The root cause is gRPC subchannel pool state could become into invalid state when global subchannel pool state is used, and there are multiple channels used the same subchannel from the pool. Closing the channel inside of waitForReady callback prevent all the remaining callbacks for the subchannel from the correct state transition handling. Closing the channel inside of waitForReady callback prevents the subchannel's remaining callbacks from the correct state transition handling. The fix is to use setImmediate to allow the remaining callbacks for the subchannel to process the state transition.
|
Hey @connor4312 could you take a look please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a race condition in Host.resetAllServices() caused by calling channel.close() as a callback of grpc.Client.waitForReady().
The root cause is gRPC subchannel pool state could become into invalid state when global subchannel pool state is used, and there are multiple channels used the same subchannel from the pool.
Closing the channel inside of waitForReady callback prevent all the remaining callbacks for the subchannel from the correct state transition handling.
Closing the channel inside of waitForReady callback prevents the subchannel's remaining callbacks from the correct state transition handling.
The fix is to use setImmediate to allow the remaining callbacks for the subchannel to process the state transition.
The issue appears with grpc-js v1.6.7.