Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slider vertical navigation and value setting bugs #3176

Merged
merged 6 commits into from
May 22, 2020
Merged

fix: slider vertical navigation and value setting bugs #3176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1cffe12
adding tests for slider
marjonlynch May 21, 2020
4fb611a
more testing
marjonlynch May 21, 2020
4056e0f
fixed some positioning issues for vertical slider, fixed initial valu…
marjonlynch May 22, 2020
c4e4c52
same navigation fix in radio group that was done in slider
marjonlynch May 22, 2020
4e1bac6
only calling getClientBoundingRect once per PR comment
marjonlynch May 22, 2020
f757105
tidy up fixture html for fast-components-msft
marjonlynch May 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/web-components/fast-components-msft/src/radio-group/fixtures/radio-group.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ <h1>Radio Group</h1>
<h4>Defaults</h4>
<div>
<fast-radio-group name="numbers">
<label slot="label">Numbers</label>
<label style="color: --var(neutral-foreground-rest)" slot="label">Numbers</label>
<fast-radio value="one">One</fast-radio>
<fast-radio value="two">Two</fast-radio>
</fast-radio-group>
Expand All @@ -13,7 +13,7 @@ <h4>Defaults</h4>
<h4>Single radio</h4>
<div style="display: flex; flex-direction: column;margin-top: 12px;">
<fast-radio-group name="players">
<label slot="label">Best basketball players</label>
<label style="color: --var(neutral-foreground-rest)" slot="label">Best basketball players</label>
<fast-radio value="airjordan">Michael Jordan</fast-radio>
</fast-radio-group>
</div>
Expand Down
Loading