feat: design-system-provider now paints CSS color and background color #3278
+126
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasrice
requested review from
awentzel,
chrisdholt,
EisenbergEffect,
Falkicon and
janechu
as code owners
janechu
approved these changes
Jun 11, 2020
EisenbergEffect
approved these changes
Jun 11, 2020
| public noPaint = false; | ||
| private noPaintChanged() { | ||
| if (!this.noPaint && this.backgroundColor !== void 0) { | ||
| this.$fastController.addStyles(backgroundStyles); |
|
Oops yes - thanks for the reminder. |
nicholasrice
force-pushed
the
users/nirice/add-background-and-color-to-DSP
branch
from
46d73cb to
bacf742
Compare
chrisdholt
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new default behavior to the Design System Provider. By default, when a background color is set on the Design System Provider, the provider will add a stylesheet that sets the background color and color CSS properties. This helps ensure that elements rendering inside the provider are styled appropriately.
The behavior can be turned off with the
no-paintattribute (open to other suggestions on the name of this attribute).Motivation & context
related to #3213
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-componentschecklistProcess & policy checklist