Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure button control height matches wc root height #3340

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

chrisdholt
Copy link
Member

@chrisdholt chrisdholt commented Jun 18, 2020

Description

A bug in the website illustrated that buttons were able to get into a state where the internal control height could get out of sync with the WC height. This PR ensures the control height matches the root height.

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@chrisdholt chrisdholt force-pushed the users/chhol/fix-button-height-inheritance-issue branch from c5a5867 to 10ce6c4 Compare June 18, 2020 21:50
Copy link
Contributor

@nicholasrice nicholasrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh! I thought I fixed that!

@EisenbergEffect EisenbergEffect mentioned this pull request Jun 18, 2020
35 tasks
@EisenbergEffect
Copy link
Contributor

Strange, I thought I reviewed a PR just like this the other day too...

@chrisdholt chrisdholt merged commit 3c9429e into master Jun 18, 2020
@chrisdholt chrisdholt deleted the users/chhol/fix-button-height-inheritance-issue branch June 18, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants