feat(fast-element): enable CSSStyleSheet and string to be used as styles #3345
+48
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EisenbergEffect
requested review from
chrisdholt,
janechu and
nicholasrice
as code owners
janechu
approved these changes
Jun 19, 2020
packages/web-components/fast-element/docs/guide/leveraging-css.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Nicholas Rice <[email protected]>
chrisdholt
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on feedback from MS Graph, who is using sass, this PR makes it easier to pass a string directly to the element definition styles. Additionally, support for passing a CSSStyleSheet instance directly to the definition, as well as composing CSSStyleSheet instances with css has been enabled. This makes FAST forward compatible with the upcoming CSS Modules platform feature which allows importing from a ".css" file where the import object is transformed by the platform into an instance of CSSStyleSheet.
This change loosens the types and is non-breaking.
Process & policy checklist