fix: update start and end slot to remove fixed width and height #4081
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On buttons and menu-item, the start and end slots have fixed width and height. This will cause elements larger than 16px to clip.
This PR removes the fixed dimension on the start and end slot but keeps the 16px on the SVG.
I also updated the
grid-template-columns
property on the menu-item that will also cause clipping with elements that are larger than 42px.This should not break any current implementation when using a
button
,anchor
, or themenu-item
. This will now allow authors to add larger elements to the start and end slots if the design calls for it.fixes #3904
Motivation & context
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-components
checklistProcess & policy checklist