[DataGrid] Add remove sort capability #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can have a method to "remove" the sort order, but :
|
dvoituron
approved these changes
Apr 11, 2024
I'll look into the a11y piece. Good point.
It is fairly common to have a way to "unsort" a column in a DataGrid (MudBlazor, Radzen and DevExpress have it too) |
Update DataGrid a11y docs
How about click for the 3rd time to remove the sort? |
No. that is not an option currently. Internally the button just looks at a boolean sortByAscending variable. Would need a lot more additional coding. |
|
I see, that could introduce a lot of work and chaos... How about have another button, like the filter button to remove the sort? |
vnbaaij
added a commit
that referenced
this pull request
Apr 29, 2024
* Add remove sort for datagrid * Undo remove sort method returning bool * A11y fixes: add keydown handler to remove column sort * Update WhatsNew Update DataGrid a11y docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previosly when a sort was executed on a DataGrid, (by clicking on a column header button or pressing enter when the column header button is focused), there was no option to undo that.
With this PR it is now possible to right click on the sorted colum header button to clear the sort and restore it to the default/start situation. updated: or use Ctrl+Enter to remove the sorting when the column header button is focused
When a grid has not sort specified, it just goes back to its initial state. When thare was a defaut sort specified, it will be restored:
Based on discussion in #283