Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Toolbar] Allow arrow keys to move cursor inside input fields #3200

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

rpodevns
Copy link
Contributor

@rpodevns rpodevns commented Jan 17, 2025

Pull Request

📖 Description

Added a new parameter to FluentToolbar (EnableArrowKeyTextNavigation) which enables arrow key navigation within text fields. This resolves an issue where the right and left arrow keys incorrectly shifted focus to the next or previous control in the tab order

🎫 Issues

Fix #3169

👩‍💻 Reviewer Notes

Is that parameter name okay?

📑 Test Plan

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

⏭ Next Steps

@vnbaaij vnbaaij changed the title [FluentToolbar] Issue/3169 toolbar arrowkeys [Toolbar] Allow arrow keys to move cursor inside input fields Jan 18, 2025
@rpodevns
Copy link
Contributor Author

@microsoft-github-policy-service agree

@vnbaaij vnbaaij merged commit 81aa14d into microsoft:dev Jan 18, 2025
4 checks passed
@rpodevns rpodevns deleted the issue/3169-toolbar-arrowkeys branch January 21, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Toolbar and keyboard navigation
2 participants