Styling update #404
Merged
Styling update #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/react-icons/package.json
Outdated
| @@ -40,7 +40,8 @@ | |||
| "yargs": "^14.0.0" | |||
| }, | |||
| "peerDependencies": { | |||
| "@griffel/react": "^1.0.0" | |||
| "@griffel/react": "^1.0.0", | |||
| "react": "^17.0.1" | |||
There was a problem hiding this comment.
This should match Fluent's range:
Suggested change
| "react": "^17.0.1" | |
| "react": ">=16.8.0 <18.0.0", |
ling1726
reviewed
Feb 11, 2022
| @@ -6,7 +6,9 @@ const useRootStyles = makeStyles({ | |||
| display: 'inline', | |||
| lineHeight: 0, | |||
|
|
|||
| "@media screen and (-ms-high-contrast: black-on-white)": {fill: 'windowtext'} | |||
| "@media (forced-colors: active)": { | |||
There was a problem hiding this comment.
I think we could be more specific and only target the svg element here. It's the actual element that has the color inherit issue
w3c/csswg-drafts#6310
https://bugs.chromium.org/p/chromium/issues/detail?id=1242706
There was a problem hiding this comment.
This should target the svg itself, there is no wrapper around it
layershifter
previously approved these changes
Feb 11, 2022
…-icons into styling-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds react as a peer dependency and adds default styling to set
forced-color-adjust: auto